Skip to content

feat(crypto): Add RoomSettings::encrypt_state_events #5511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025

Conversation

kaylendog
Copy link
Contributor

@kaylendog kaylendog commented Aug 11, 2025

  • Add RoomSettings::encrypt_state_events, which will be used when implementing encrypted state support to the WASM SDK.

Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.57%. Comparing base (b3c53dd) to head (ec2918a).
⚠️ Report is 12 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5511      +/-   ##
==========================================
- Coverage   88.57%   88.57%   -0.01%     
==========================================
  Files         340      340              
  Lines       93665    93667       +2     
  Branches    93665    93667       +2     
==========================================
- Hits        82967    82964       -3     
- Misses       6567     6572       +5     
  Partials     4131     4131              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaylendog kaylendog marked this pull request as ready for review August 11, 2025 14:23
@kaylendog kaylendog requested review from a team as code owners August 11, 2025 14:23
@kaylendog kaylendog requested review from bnjbvr and richvdh and removed request for a team August 11, 2025 14:23
Copy link

codspeed-hq bot commented Aug 11, 2025

CodSpeed Performance Report

Merging #5511 will not alter performance

Comparing kaylendog:kaylendog/room-settings (ec2918a) with main (b3c53dd)

Summary

✅ 31 untouched benchmarks

@bnjbvr bnjbvr removed their request for review August 12, 2025 08:24
@kaylendog kaylendog force-pushed the kaylendog/room-settings branch 3 times, most recently from cca7e81 to 6af8908 Compare August 12, 2025 10:30
@kaylendog kaylendog requested a review from richvdh August 12, 2025 13:25
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good other than a couple of nits!

@kaylendog kaylendog force-pushed the kaylendog/room-settings branch from 6af8908 to ec2918a Compare August 13, 2025 14:58
@richvdh richvdh merged commit d9f4e7c into matrix-org:main Aug 14, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants